netdev - Re: [PATCH] sfc: lower stack usage in efx_ethtool_self

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110222.101221.183057993.davem@davemloft.net>
Date:	Tue, 22 Feb 2011 10:12:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] sfc: lower stack usage in efx_ethtool_self_test

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 21 Feb 2011 16:09:21 +0000

> On Wed, 2011-02-16 at 14:48 +0100, Eric Dumazet wrote:
>> drivers/net/sfc/ethtool.c: In function ‘efx_ethtool_self_test’:
>> drivers/net/sfc/ethtool.c:613: warning: the frame size of 1200 bytes
>> is larger than 1024 bytes
> 
> This also fixes a whopping information leak in case the device is in a
> broken state.
> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Acked-by: Ben Hutchings <bhutchings@...arflare.com>

Ok, I'll apply this to net-2.6, thanks!