netdev - Re: [PATCH 1/2 net-next-2.6] r6040: fix multicast operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110223.142254.59671988.davem@davemloft.net>
Date:	Wed, 23 Feb 2011 14:22:54 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	florian@...nwrt.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2 net-next-2.6] r6040: fix multicast operations

From: Florian Fainelli <florian@...nwrt.org>
Date: Wed, 23 Feb 2011 15:32:34 +0100

> From: Shawn Lin <shawn@....com.tw>
> 
> The original code does not work well when the number of mulitcast
> address to handle is greater than MCAST_MAX. It only enable promiscous
> mode instead of multicast hash table mode, so the hash table function
> will not be activated and all multicast frames will be recieved in this
> condition.
> 
> This patch fixes the following issues with the r6040 NIC operating in
> multicast:
> 
> 1) When the IFF_ALLMULTI flag is set, we should write 0xffff to the NIC
> hash table registers to make it process multicast traffic.
> 
> 2) When the number of multicast address to handle is smaller than
> MCAST_MAX, we should use the NIC multicast registers MID1_{L,M,H}.
> 
> 3) The hashing of the address was not correct, due to an invalid
> substraction (15 - (crc & 0x0f)) instead of (crc & 0x0f) and an
> incorrect crc algorithm (ether_crc_le) instead of (ether_crc).
> 
> 4) If necessary, we should set HASH_EN flag in MCR0 to enable multicast
> hash table function.
> 
> CC: stable@...nel.org

If it's not appropriate for net-2.6, it's not appropriate for -stable
either.

I'm applying this to net-next-2.6, as you requested, and removing the
stable CC: tag from the commit message.

> Reported-by: Marc Leclerc <marc-leclerc@...naturealpha.com>
> Tested-by: Marc Leclerc <marc-leclerc@...naturealpha.com>
> Signed-off-by: Shawn Lin <shawn@....com.tw>
> Signed-off-by: Albert Chen <albert.chen@....com.tw>
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html