lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Feb 2011 09:30:01 -0800 From: Stephen Hemminger <shemminger@...tta.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: Patrick McHardy <kaber@...sh.net>, David Miller <davem@...emloft.net>, Juliusz Chroboczek <Juliusz.Chroboczek@....jussieu.fr>, "John W. Linville" <linville@...driver.com>, netdev <netdev@...r.kernel.org>, Andi Kleen <andi@...stfloor.org> Subject: Re: [PATCH] net_sched: long word align struct qdisc_skb_cb data On Wed, 23 Feb 2011 18:05:07 +0100 Eric Dumazet <eric.dumazet@...il.com> wrote: > Le mercredi 23 février 2011 à 17:24 +0100, Patrick McHardy a écrit : > > Am 23.02.2011 16:14, schrieb Eric Dumazet: > > > diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h > > > index 16626a0..f40d32e 100644 > > > --- a/include/net/sch_generic.h > > > +++ b/include/net/sch_generic.h > > > @@ -218,6 +218,7 @@ struct tcf_proto { > > > > > > struct qdisc_skb_cb { > > > unsigned int pkt_len; > > > + unsigned int sfb_classid; > > > char data[]; > > > }; > > > > This could be moved into a SFB specific cb, similar to what netem > > does. > > Hmm... well... I want to be sure no other sch will destroy my values. > > netem seems buggy then. > > Probably following patch is needed ? Yes, it was long word aligned when netem was written but we seem to have bit creep. -- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists