netdev - Re: via-rhine -- VT6105M and checksum offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110225075303.GA8748@core.hellgate.ch>
Date:	Fri, 25 Feb 2011 08:53:03 +0100
From:	Roger Luethi <rl@...lgate.ch>
To:	Benjamin LaHaise <bcrl@...ck.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: via-rhine -- VT6105M and checksum offloading

On Thu, 24 Feb 2011 12:23:54 -0800, David Miller wrote:
> From: Benjamin LaHaise <bcrl@...ck.org>
> Date: Thu, 24 Feb 2011 13:58:05 -0500
> 
> > Upon investigation, it looks like the VT6105M isn't actually using the 
> > hardware checksum offloading support of the hardware.  Are there any 
> > known reasons why this isn't enabled (hardware bugs?)?  I'll test enabling 
> 
> As far as I can tell it was never attempted.  So it should work.
> 
> If you do that, while you're here, you can make rhine_rx() take
> a "napi" arg and make this driver use netif_gso_receive() too.
> Don't forget to set NETIF_F_GRO or similar in netdev->flags during
> probe, and also hookup the necessary ethtool hooks.

I have a patch to enable hw checksumming (the ethtool hooks are done, but I
somehow missed the NETIF_F_GRO bit). Care to give it a whirl?

Roger

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html