netdev - Re: check for return value of clk_get() in mpc512x_can_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 25 Feb 2011 09:34:37 +0100
From:	Wolfgang Grandegger <wg@...ndegger.com>
To:	Andrej Krutak <andrej.krutak@...go.com>
CC:	socketcan-core@...ts.berlios.de, netdev@...r.kernel.org
Subject: Re: check for return value of clk_get() in mpc512x_can_get_clock()

Hi,

On 02/23/2011 02:35 PM, Andrej Krutak wrote:
> Hi,
> 
> just wanted to inform you - in the mpc512x_can_get_clock() function 
> (drivers/net/can/mscan/mpc5xxx_can.c), there are calls to clg_get(), and later 
> checks
> 
> if (!sys_clk) {
> and
> if (!ref_clk) {
> 
> but these should be
> 
> if (IS_ERR(sys_clk)) {
> and
> if (IS_ERR(ref_clk)) {
> 
> (otherwise you'll get an oops if something goes wrong with clg_get()).

Thanks for the info. I'm going to prepare a patch.

Wolfgang.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html