netdev - Re: [Xen-devel] Re: [PATCH v2] xen network backend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1298648153.5034.549.camel@zakaz.uk.xensource.com>
Date:	Fri, 25 Feb 2011 15:35:53 +0000
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	Ben Hutchings <bhutchings@...arflare.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	xen-devel <xen-devel@...ts.xensource.com>,
	Herbert Xu <herbert@...dor.hengli.com.au>
Subject: Re: [Xen-devel] Re: [PATCH v2] xen network backend driver

On Thu, 2011-02-24 at 13:23 +0000, Ian Campbell wrote:
> 
> > > +
> > > +     if (HYPERVISOR_grant_table_op(GNTTABOP_map_grant_ref, &op,
> 1))
> > > +             BUG();
> > 
> > How about something less severe? Say return the error code?
> 
> Yes, I folded this into the following check of op.status. 

I revisited this and HYPERVISOR_grant_table_op has multicall like
semantics and a failure of the hypercall itself is a serious bug in the
calling kernel, akin to a page fault on kernel memory or similar so I
think a BUG() is the appropriate response.

Failures of the type which a guest may cause are the GNTST_* error codes
found in the op.status field an are handled appropriately gracefully.

Ian.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html