netdev - Re: [PATCH net-next-2.6] ethtool: Compat handling for struct ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110228.110655.71121452.davem@davemloft.net>
Date:	Mon, 28 Feb 2011 11:06:55 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	alexander.h.duyck@...el.com, santwona.behera@....com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] ethtool: Compat handling for struct
 ethtool_rxnfc

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 28 Feb 2011 18:22:26 +0000

> This structure was accidentally defined such that its layout can
> differ between 32-bit and 64-bit processes.  Add compat structure
> definitions and functions to copy from/to user-space with the
> necessary adjustments.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Please implement this via the proper contextual compat ioctl handling
in net/socket.c

Using is_compat_task() is heavily discouraged.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html