netdev - Re: [PATCH] macb: don't use platform_set_drvdata() on a net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110228.122233.115936736.davem@davemloft.net>
Date:	Mon, 28 Feb 2011 12:22:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jamie@...ieiles.com
Cc:	netdev@...r.kernel.org, nicolas.ferre@...el.com
Subject: Re: [PATCH] macb: don't use platform_set_drvdata() on a net_device

From: Jamie Iles <jamie@...ieiles.com>
Date: Mon, 28 Feb 2011 14:05:25 +0000

> Commit 71d6429 (Driver core: convert platform_{get,set}_drvdata to
> static inline functions) now triggers a warning in the macb network
> driver:
> 
>   CC      drivers/net/macb.o
> drivers/net/macb.c: In function ‘macb_mii_init’:
> drivers/net/macb.c:263: warning: passing argument 1 of ‘platform_set_drvdata’ from incompatible pointer type
> include/linux/platform_device.h:138: note: expected ‘struct platform_device *’ but argument is of type ‘struct net_device *’
> 
> Use dev_set_drvdata() on the device embedded in the net_device instead.
> 
> Cc: Nicolas Ferre <nicolas.ferre@...el.com>
> Signed-off-by: Jamie Iles <jamie@...ieiles.com>

Applied.