netdev - Re: [PATCH] cxgb{3,4}: streamline Kconfig options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Feb 2011 13:19:10 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	JBeulich@...ell.com
Cc:	dm@...lsio.com, divy@...lsio.com, linux-kbuild@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] cxgb{3,4}: streamline Kconfig options

From: "Jan Beulich" <JBeulich@...ell.com>
Date: Mon, 28 Feb 2011 08:19:58 +0000

>>>> On 25.02.11 at 20:51, Dimitris Michailidis <dm@...lsio.com> wrote:
>> Dimitris Michailidis wrote:
>>> Jan Beulich wrote:
>>> 
>>>> As to that INET vs NET dependency - is it possible that the
>>>> network drivers really just need NET, but the iSCSI ones need
>>>> INET? In which case the only common dependency would be
>>>> PCI - certainly not worth a custom helper option.
>>> 
>>> Reading the commit message that introduced CHELSIO_T3_DEPENDS, it talks 
>>> of hidden dependencies that select does not see.  I am not sure which 
>>> exactly but since it's been a few years since that commit I'll try to 
>>> see what the situation is today without the *_DEPENDS symbols and let 
>>> you know.
>> 
>> I looked into this and found that with the current Kconfig the iSCSI driver 
>> does not appear in the SCSI menu until one first enables NETDEVICES and 
>> NETDEV_10000 in the network driver menu.  It appears that the *_DEPENDS 
>> symbols were added to capture dependencies on such symbols within the 
>> network driver Kconfig, besides the dependencies the driver's entry listed 
>> explicitly.
>> 
>> The patch below removes *T4*_DEPENDS and the network drivers' unnecessary 
>> dependency on INET, and updates the iSCSI driver's entry so it is visible 
>> without requiring any net driver options to be enabled first and has 
>> adequate selects to be able to build the net driver (this part is adapted 
>> from bnx2i's Kconfig entry).  I still need to do the T3 part of this and 
>> check that there isn't a conflict with the current scsi tree.  Just for 
>> review at this time.
> 
> Thanks, this looks good to me.

Dimitris, please submit this anew with a proper commit log messag and
signoff.  Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html