netdev - Re: [Open-FCoE] [PATCH] fcoe: correct checking for bonding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1299002987.7692.206.camel@vi2.jf.intel.com>
Date:	Tue, 01 Mar 2011 10:09:47 -0800
From:	Vasu Dev <vasu.dev@...ux.intel.com>
To:	Joe Eykholt <joe.eykholt@...il.com>
Cc:	linux-scsi@...r.kernel.org, Jiri Pirko <jpirko@...hat.com>,
	netdev@...r.kernel.org, Jay Vosburgh <fubar@...ibm.com>,
	James.Bottomley@...senPartnership.com, devel@...n-fcoe.org
Subject: Re: [Open-FCoE] [PATCH] fcoe: correct checking for bonding

On Tue, 2011-03-01 at 10:01 -0800, Vasu Dev wrote:
> On Tue, 2011-03-01 at 09:49 -0800, Joe Eykholt wrote:
> > 
> > Otherwise I'd add some parens or I might code this as:
> > 
> >         if ((netdev->priv_flags & (IFF_BONDING | IFF_MASTER)) ==
> >             (IFF_BONDING | IFF_MASTER))
> 
> or also skip == in code as:-
> 
> if (netdev->priv_flags & (IFF_BONDING | IFF_MASTER)) 
> 
> Would least save few chars in source code.

Never mind, you wanted to check both bits set instead checking only one
of them, my mistake, anycase these are in different fields as another
most recent response mentioned.

	Vasu

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html