lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 01 Mar 2011 09:33:05 +0000 From: "Jan Beulich" <JBeulich@...ell.com> To: "Dimitris Michailidis" <dm@...lsio.com> Cc: <linux-scsi@...r.kernel.org>, <netdev@...r.kernel.org> Subject: Re: [PATCH] cxgb{3,4}*: improve Kconfig dependencies >>> On 01.03.11 at 10:10, Dimitris Michailidis <dm@...lsio.com> wrote: > Jan Beulich wrote: >>>>> On 01.03.11 at 04:34, Dimitris Michailidis <dm@...lsio.com> wrote: >>> - Remove the dependency of cxgb4 and cxgb4vf on INET. cxgb3 really >>> depends on INET, keep it but add it directly to the driver's Kconfig >>> entry. >>> - Make the iSCSI drivers cxgb3i and cxgb4i available in the SCSI menu >>> without requiring any options in the net driver menu to be enabled >>> first. Add needed selects so the iSCSI drivers can build their >>> corresponding net drivers. >>> - Remove CHELSIO_T*_DEPENDS. >>> >>> Signed-off-by: Dimitris Michailidis <dm@...lsio.com> >>> --- >>> drivers/net/Kconfig | 21 +++------------------ >>> drivers/scsi/cxgbi/cxgb3i/Kconfig | 4 +++- >>> drivers/scsi/cxgbi/cxgb4i/Kconfig | 4 +++- >>> 3 files changed, 9 insertions(+), 20 deletions(-) >>> >>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig >>> index f4b3927..6e09d5f 100644 >>> --- a/drivers/net/Kconfig >>> +++ b/drivers/net/Kconfig >>> @@ -2595,14 +2595,9 @@ config CHELSIO_T1_1G >>> Enables support for Chelsio's gigabit Ethernet PCI cards. If you >>> are using only 10G cards say 'N' here. >>> >>> -config CHELSIO_T3_DEPENDS >>> - tristate >>> - depends on PCI && INET >>> - default y >>> - >>> config CHELSIO_T3 >>> tristate "Chelsio Communications T3 10Gb Ethernet support" >>> - depends on CHELSIO_T3_DEPENDS >>> + depends on PCI && INET >> >> Forgot to remove INET here? > > Didn't forget it, this driver has a real dependency on INET (ARP more > specifically). I mentioned it also in the commit message. Oh, sorry, must have read this too quickly. Jan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists