netdev - RE: [net-next-2.6 PATCH 02/10] ethtool: add ntuple flow specifier to network flow classifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8A71B368A89016469F72CD08050AD334091C1FAB@maui.asicdesigners.com>
Date:	Wed, 2 Mar 2011 11:11:16 -0800
From:	"Dimitrios Michailidis" <dm@...lsio.com>
To:	"Ben Hutchings" <bhutchings@...arflare.com>,
	"Alexander Duyck" <alexander.duyck@...il.com>
Cc:	"Alexander Duyck" <alexander.h.duyck@...el.com>,
	<davem@...emloft.net>, <jeffrey.t.kirsher@...el.com>,
	<netdev@...r.kernel.org>
Subject: RE: [net-next-2.6 PATCH 02/10] ethtool: add ntuple flow specifier to network flow classifier

Ben Hutchings wrote:
> /**
>  * struct ethtool_flow_ext - flow spec common extension fields
>  * @vlan_etype: EtherType for vlan tagged packet to match
>  * @vlan_tci: VLAN tag to match
>  * @data: Driver-dependent data to match
>  *
>  * Note: Additional fields may be inserted before @vlan_etype in future,
>  * but the offset of the existing fields within the containing structure
>  * (&struct ethtool_rx_flow_spec) will be stable.
>  */
> struct ethtool_flow_ext {
> 	__be16	vlan_etype;
> 	__be16	vlan_tci;
> 	__be32	data[2];
> };

I am wondering about the semantics of these vlan_* fields.  Is vlan_etype the
Ethertype in the VLAN header or the type after it?  Specifically, I am wondering
whether these fields are limited to VLANs or can work with general Ethertypes and the
2 bytes after them.