netdev - Re: fcoe: correct checking for bonding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110302095550.GA2858@psychotron.brq.redhat.com>
Date:	Wed, 2 Mar 2011 10:55:51 +0100
From:	Jiri Pirko <jpirko@...hat.com>
To:	linux-scsi@...r.kernel.org, davem@...emloft.net
Cc:	devel@...n-fcoe.org, robert.w.love@...el.com,
	netdev@...r.kernel.org, fubar@...ibm.com, joe.eykholt@...il.com
Subject: Re: fcoe: correct checking for bonding

Or perhaps this should be applied to net-next?

Wed, Mar 02, 2011 at 07:05:35AM CET, jpirko@...hat.com wrote:
>Check for bonding master and refuse to use that.
>
>Signed-off-by: Jiri Pirko <jpirko@...hat.com>
>---
> drivers/scsi/fcoe/fcoe.c |    4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
>index 9f9600b..3becc6a 100644
>--- a/drivers/scsi/fcoe/fcoe.c
>+++ b/drivers/scsi/fcoe/fcoe.c
>@@ -285,9 +285,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe,
> 	}
> 
> 	/* Do not support for bonding device */
>-	if ((netdev->priv_flags & IFF_MASTER_ALB) ||
>-	    (netdev->priv_flags & IFF_SLAVE_INACTIVE) ||
>-	    (netdev->priv_flags & IFF_MASTER_8023AD)) {
>+	if (netdev->priv_flags & IFF_BONDING && netdev->flags & IFF_MASTER) {
> 		FCOE_NETDEV_DBG(netdev, "Bonded interfaces not supported\n");
> 		return -EOPNOTSUPP;
> 	}
>-- 
>1.7.3.4
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html