netdev - Re: [PATCH] sched: QFQ - quick fair queue scheduler (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Mar 2011 16:07:44 +0100
From:	Fabio Checconi <fchecconi@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Stephen Hemminger <shemminger@...tta.com>,
	David Miller <davem@...emloft.net>,
	Luigi Rizzo <rizzo@....unipi.it>, netdev@...r.kernel.org,
	Paolo Valente <paolo.valente@...more.it>
Subject: Re: [PATCH] sched: QFQ - quick fair queue scheduler (v2)

> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Thu, Mar 03, 2011 11:40:20AM +0100
>
> Le jeudi 03 mars 2011 à 09:27 +0100, Eric Dumazet a écrit :
> 
> > I am going to test an updated version, thanks for all these hints !
> > 
> 
> Same problem in qfq_qlen_notify()
> 
> Should use :
> 
> struct qfq_sched *q = qdisc_priv(sch);
> 

Absolutely right, as you're right about qfq_drop().  I'll be able to take
a look when I'm back from work this evening.

A question on the data below:

> After a stress (and no more trafic) I still have some packets in
> backlog:
> 
> (8 packets here)
> 
...
> class qfq 11:10 root weight 1600 maxpkt 2048 
>  Sent 200 bytes 1 pkt (dropped 18181, overlimits 0 requeues 0) 
>  rate 0bit 0pps backlog 200b 0p requeues 0 

Any other reason, apart from a bug in QFQ, why there could be 200b and
0p of backlog?  A packet count out of sync could explain also why you
were experiencing problems with pfifo in presence of drops...

Thanks for your help, fixes, and testing,
fabio
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html