netdev - Re: [PATCH net-next-2.6] net_sched: reduce fifo qdisc size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 03 Mar 2011 11:10:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] net_sched: reduce fifo qdisc size

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 03 Mar 2011 14:27:45 +0100

> Because of various alignements [SLUB / qdisc], we use 512 bytes of
> memory for one {p|b}fifo qdisc, instead of 256 bytes on 64bit arches and
> 192 bytes on 32bit ones.
> 
> Move the "u32 limit" inside "struct Qdisc" (no impact on other qdiscs)
> 
> Change qdisc_alloc(), first trying a regular allocation before an
> oversized one.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

It took me a moment to realize that leaving sch->padded uninitialized
in the sch==p case during allocation was legal ;-)

Applied, thanks!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html