netdev - Re: [PATCH 2/3 v2] mii: Convert printks to netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 Mar 2011 12:56:43 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/3 v2] mii: Convert printks to netdev_info

From: Joe Perches <joe@...ches.com>
Date: Thu, 03 Mar 2011 12:46:30 -0800

> Add a bit more data to the output.
> Convert string speeds to integer.
> Object size reduced a tiny bit.
> $ size drivers/net/mii.o*
>    text	   data	    bss	    dec	    hex	filename
>    4155	     56	   1000	   5211	   145b	drivers/net/mii.o.new
>    4184	     56	   1000	   5240	   1478	drivers/net/mii.o.old
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied.

> I believe I did this:
> 
> <edits drivers/net/mii.c>
> make drivers/net/mii.o
> git commit -s drivers/net/mii.c
> mv drivers/net/mii.o drivers/net/mii.o.new
> git checkout master -- drivers/net/mii.c
> make drivers/net/mii.o
> mv drivers/net/mii.o drivers/net/mii.i.old
> git checkout <branch> -- drivers/net/mii.c
> size drivers/net/mii.o.*
>  etc...
> git commit --amend drivers/net/mii.c (add etc...)
> 
> tun revert?  No mii change?  huh?

I think the definition of "last commit" used by --amend might be the
issue in this case.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html