netdev - Re: [PATCH] sched: QFQ - quick fair queue scheduler (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110303160343.71c55274@nehalam>
Date:	Thu, 3 Mar 2011 16:03:43 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Fabio Checconi <fabio@...dalf.sssup.it>,
	Luigi Rizzo <rizzo@....unipi.it>, netdev@...r.kernel.org
Subject: Re: [PATCH] sched: QFQ - quick fair queue scheduler (v3)

On Thu, 03 Mar 2011 23:28:53 +0100
Eric Dumazet <eric.dumazet@...il.com> wrote:

> Here there is the problem of *pp = cl->next (possibly NULL)
> 
> 		maybe use
> 
> 	for (pp = &grp->slots[j]; (cl = *pp) != NULL;) {
> 		if (cl->qdisc->q.len)
> 			qfq_deactivate_class(...);
> 		else
> 			pp = &cl->next;
> 	}
> 

I think changing slots from open coded linked list
to double linked list (list_for_each) would be clearer
and avoid these kind of bugs. That is what DRR does.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html