netdev - Re: [PATCH] e1000: power off PHY after reset when interface is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTim-T99r+npYWCLH8ry+hbtCNBOM4WUev8soaoM6@mail.gmail.com>
Date:	Fri, 4 Mar 2011 00:19:42 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	"prasanna.panchamukhi@...erbed.com" 
	<prasanna.panchamukhi@...erbed.com>
Cc:	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Pieper, Jeffrey E" <jeffrey.e.pieper@...el.com>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] e1000: power off PHY after reset when interface is down

On Wed, Feb 23, 2011 at 16:02, Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:
> On Tue, 2011-02-22 at 17:25 -0800, prasanna.panchamukhi@...erbed.com
> wrote:
>> From: Prasanna S. Panchamukhi <prasanna.panchamukhi@...erbed.com>
>>
>> Some Phys supported by the e1000 driver do not remain powered off
>> across
>> a reset of the device when the interface is down, e.g. on 82546.
>> This patch powers down (only when WoL is disabled) the PHY after reset
>> if
>> the interface is down and ethtool diagnostics are not currently
>> running.
>>
>> Similar problem was see on 82571 controller and was fixed in e1000e
>> driver
>> by Bruce Allan.
>> Please refer commit 31dbe5b4ac6fca72dec946e4d0fa7f0913f1d9b1 for
>> details.
>>
>> Signed-off-by: Prasanna S. Panchamukhi
>> <prasanna.panchamukhi@...erbed.com>
>> ---
>>  drivers/net/e1000/e1000_ethtool.c |   27 +++++++++++++++++++--------
>>  drivers/net/e1000/e1000_main.c    |    7 +++++++
>>  2 files changed, 26 insertions(+), 8 deletions(-)
>
> Thanks Prasanna!  I have added the patch to my queue of e1000 patches.
>

Prasanna-
Here is what we found during validating your patch:

The behavior of 82546 device(s) seems to be identical with/without this patch
applied. 82546GB (LOM), dev_id 1079 powers down (with wol disabled) after
ifdown, but powers back up after approx. 10 seconds. 82546EB (NIC), dev_id
1010 powers down (with wol disabled) after ifdown. Both of the above
behaviors are the same with and without the patch applied. Also, if this patch
DID work as expected, it should print a message after a reset, such as "Cannot
restart autonegotiation: Resource temporarily unavailable", which would mirror
the behavior of e1000e.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html