netdev - Re: [patch net-next-2.6 7/8] net: introduce rx_handler results and logic around that

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTi=AYQsO4F3s3Mqxj6QaT=xMKp_hBE12qC3e0uF-@mail.gmail.com>
Date:	Sun, 6 Mar 2011 00:45:47 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	Jiri Pirko <jpirko@...hat.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	shemminger@...ux-foundation.org, kaber@...sh.net, fubar@...ibm.com,
	eric.dumazet@...il.com, nicolas.2p.debian@...il.com,
	andy@...yhouse.net
Subject: Re: [patch net-next-2.6 7/8] net: introduce rx_handler results and
 logic around that

On Sat, Mar 5, 2011 at 4:29 PM, Jiri Pirko <jpirko@...hat.com> wrote:
>
> -typedef struct sk_buff *rx_handler_func_t(struct sk_buff *skb);
> +enum rx_handler_result {
> +       RX_HANDLER_CONSUMED,
> +       RX_HANDLER_ANOTHER,
> +       RX_HANDLER_EXACT,
> +       RX_HANDLER_PASS,
> +};

Why not extend the macros NET_RX_SUCCESS and NET_RX_DROP?  Then the
callers of __netif_receive_skb() may get the right congestion info
from its return value.

-- 
Regards,
Changli Gao(xiaosuo@...il.com)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html