netdev - Possible regression in __netif_receive_skb() between 2.6.38-rc7 and net-next-2.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D72AB79.3000605@gmail.com>
Date:	Sat, 05 Mar 2011 22:30:33 +0100
From:	Nicolas de Pesloüan 
	<nicolas.2p.debian@...il.com>
To:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	Jiri Pirko <jpirko@...hat.com>, David Miller <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...tta.com>,
	Jay Vosburgh <fubar@...ibm.com>,
	Patrick Mc Hardy <kaber@...sh.net>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>
Subject: Possible regression in __netif_receive_skb() between 2.6.38-rc7 and
 net-next-2.6

Hi,

Comparing __netif_receive_skb() between 2.6.38-rc7 and net-next-2.6, I noticed an important 
difference: The ptype_base loop used to deliver to orig_dev and this is not true anymore.

[Note that this is unrelated to Jiri's today's patch that remove the orig_dev parameter to protocol 
handler].

Imagine the following simple setup:

eth0 -> bond0

- A packet handler registered on eth0, with ptype->type == NULL will receive the packet, because it 
will be delivered in the ptype_all loop, which is inside the another_round loop.
- The same packet handler, registered on eth0, but with ptype->type != NULL won't receive the 
packet, because the ptype_base loop doesn't deliver to orig_dev anymore.

I think this can lead to a regression for user space: an application using af_packet to listen to 
eth0 will receive the packet flow if the registered protocol is NULL, but won't receive anything if 
the registered protocol is not NULL.

Can someone confirm?

	Nicolas.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html