netdev - Re: [PATCH] ipv4: Remove flowi from struct rtable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1299308388.2758.71.camel@edumazet-laptop>
Date:	Sat, 05 Mar 2011 07:59:48 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: Remove flowi from struct rtable.

Le vendredi 04 mars 2011 à 22:12 -0800, David Miller a écrit :
> The only necessary parts are the src/dst addresses, the
> interface indexes, the TOS, and the mark.
> 
> The rest is unnecessary bloat, which amounts to nearly
> 50 bytes on 64-bit.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---

> +		struct rtable *rt = skb_rtable(skb);
> +		struct flowi fl = {
> +			.fl4_dst = rt->rt_key_dst,
> +			.fl4_src = rt->rt_key_src,
> +			.fl4_tos = rt->rt_tos,
> +			.oif = rt->rt_oif,
> +			.iif = rt->rt_iif,
> +			.mark = rt->rt_mark,
> +		};

Eventually we could have a helper for this, as this is done three times
in this file. Or maybe you have further plans for ipmr ?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html