netdev - Re: [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110307195616.GA14888@kroah.com>
Date:	Mon, 7 Mar 2011 11:56:16 -0800
From:	Greg KH <greg@...ah.com>
To:	Narendra_K@...l.com
Cc:	a.beregalov@...il.com, linux-next@...r.kernel.org,
	jbarnes@...tuousgeek.org, linux-pci@...r.kernel.org,
	linux-hotplug@...r.kernel.org, netdev@...r.kernel.org,
	mjg@...hat.com, Matt_Domsch@...l.com, Charles_Rose@...l.com,
	Jordan_Hargrave@...l.com, Shyam_Iyer@...l.com, sfr@...b.auug.org.au
Subject: Re: [PATCH V4] Export ACPI _DSM provided firmware instance number
 and string name to sysfs

On Mon, Mar 07, 2011 at 11:44:52AM -0800, Narendra_K@...l.com wrote:
> --- a/drivers/pci/pci-label.c
> +++ b/drivers/pci/pci-label.c
> @@ -29,7 +29,9 @@
>  #include <linux/nls.h>
>  #include <linux/acpi.h>
>  #include <linux/pci-acpi.h>
> +#ifdef CONFIG_ACPI
>  #include <acpi/acpi_drivers.h>
> +#endif

You should never need a #ifdef in a .c file for an include file.  If so,
something is really wrong.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html