netdev - Re: [Patch] ariadne: fix possible null dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 06 Mar 2011 18:07:58 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	geert@...ux-m68k.org
Cc:	rdunlap@...otime.net, j223yang@...et.uwaterloo.ca,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Patch] ariadne: fix possible null dereference

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Sun, 6 Mar 2011 21:00:13 +0100

> On Sun, Mar 6, 2011 at 20:11, Randy Dunlap <rdunlap@...otime.net> wrote:
>> On Sun, 6 Mar 2011 02:08:32 -0500 j223yang@...et.uwaterloo.ca wrote:
>>
>>> Hi Randy,
>>> I have tested my patch, and it is ok now.
>>> Could you please try patching again? Sorry for previous trouble.
>>> Thank you!
>>
>> Acked-by: Randy Dunlap <rdunlap@...otime.net>
> 
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

People really don't actually read patches, I think.

Show me how dev can even be NULL here, it simply can't.

So the correct fix is to remove the dev==NULL check altogether.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html