[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20110307.160315.13736027.davem@davemloft.net>
Date: Mon, 07 Mar 2011 16:03:15 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: nils.carlson@...csson.com
Cc: fubar@...ibm.com, andy@...yhouse.net, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] bonding 802.3ad: Fix the state machine locking v2
From: Nils Carlson <nils.carlson@...csson.com>
Date: Fri, 4 Mar 2011 09:09:11 +0100
> Changes since v1:
> * Clarify an unclear comment
> * Move a (possible) name change to a separate patch
>
> The ad_rx_machine, ad_periodic_machine and ad_port_selection_logic
> functions all inspect and alter common fields within the port structure.
> Previous to this patch, only the ad_rx_machines were mutexed, and the
> periodic and port_selection could run unmutexed against an ad_rx_machine
> trigged by an arriving LACPDU.
>
> This patch remedies the situation by protecting all the state machines
> from concurrency. This is accomplished by locking around all the state
> machines for a given port, which are executed at regular intervals; and
> the ad_rx_machine when handling an incoming LACPDU.
>
> Signed-off-by: Nils Carlson <nils.carlson@...csson.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists