netdev - Re: [PATCH 1/8] Phonet: fix NULL-deref in a8059512b120362b15424f152b2548fe8b11bd0c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110308.112923.39177383.davem@davemloft.net>
Date:	Tue, 08 Mar 2011 11:29:23 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	remi.denis-courmont@...ia.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/8] Phonet: fix NULL-deref in
 a8059512b120362b15424f152b2548fe8b11bd0c

From: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>
Date: Tue,  8 Mar 2011 15:56:59 +0200

> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>

You don't even read what I tell you, which makes reviewing your work
insanely frustrating.

I said:

	Reference other changes like a man, by mentioned the SHA1 ID and
	giving the commit message header line inside of ("") right
	afterwards. :-)

I didn't say to put the SHA1 reference in the subject line, it's
so messy there.  Put it in the commit message.  Do you see other
people putting commit ID references in the commit header line?

Also, I said explicitly to reference the commit like this:

	$(SHA1_ID) ("commit message header line")

so in this case it would be:

	a8059512b120362b15424f152b2548fe8b11bd0c ("Phonet: implement
	per-socket destination/peer address")

because when commits get backported that SHA1_ID might be different
in the tree it gets backported to, so you have to provide that
textual reference to the commit so that in such a case it can still
be matched up.

It also irks me that you persisted to provide the most terse possible
one-line commit message.  Have a conversation in your commit message,
this isn't for you it's for other people trying to understand your
work.

The commit message header line just gives a top-level description.
Details like the reasoning, reference to relevant commits, etc.
belong in the commit message contents.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html