netdev - Re: [PATCH 11/17] mlx4_en: Enabling new steering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110308.142649.183050876.davem@davemloft.net>
Date:	Tue, 08 Mar 2011 14:26:49 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	roland@...nel.org
Cc:	or.gerlitz@...il.com, yevgenyp@...lanox.co.il,
	netdev@...r.kernel.org, vlad@...lanox.co.il, nirmu@...lanox.com,
	alekseys@...lanox.com
Subject: Re: [PATCH 11/17] mlx4_en: Enabling new steering

From: Roland Dreier <roland@...nel.org>
Date: Tue, 8 Mar 2011 13:30:25 -0800

> On Tue, Mar 8, 2011 at 1:10 PM, Or Gerlitz <or.gerlitz@...il.com> wrote:
>>> +       if (mdev->dev->caps.vep_mc_steering && ibqp->qp_type == IB_QPT_RAW_ETHERTYPE) {
>>
>> Guys,
>>
>> Didn't you want to refer here to the "raw ethernet QP" which is typed
>> to IB_QPT_RAW_PACKET by the series posted on December last year, see
>> http://marc.info/?l=linux-rdma&m=129162076818154  --
>> IB_QPT_RAW_ETHERTYPE  is a rename of IB's IB_QPT_RAW_ETY done by
>> commit a2ebf07ae53e65bd073f96877e4818f2e89271ae
> 
> Good catch.  I think the drivers/infiniband part of this patch should
> just be dropped -- we don't have any raw QP support of any kind, right?

Once this is all sorted out, please someone respin this entire patch
set.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html