netdev - Re: [PATCH] ipv4: Cache source address in nexthop entries.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110309.130817.115943793.davem@davemloft.net>
Date:	Wed, 09 Mar 2011 13:08:17 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ja@....bg
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: Cache source address in nexthop entries.

From: Julian Anastasov <ja@....bg>
Date: Wed, 9 Mar 2011 02:49:49 +0200 (EET)

> 	But we still need to propagate the address events
> to nexthops on all devices. Even if it is slow, I see it in
> this way (not tested):

Ok, I think it is even more involved than what you propose.

We have to potentially re-run inet_select_addr() on all nexthops, even
those pointing to devices other than the one being modified, because
when an interface loses it's last IP address we have to look for a
source address to use on other active interfaces.

Probably it makes sense to recompute this at use time instead of
walking all of this stuff at every event.

So device address operations increment a generation ID and
FIB_RES_PREFSRC() checks that ID against one stored in the nexthop.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html