netdev - Re: [PATCH 3/6] tcp_cubic: fix comparison of jiffies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110311094022.GA15941@xanadu.blop.info>
Date:	Fri, 11 Mar 2011 10:40:22 +0100
From:	Lucas Nussbaum <lucas.nussbaum@...ia.fr>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	davem@...emloft.net, sangtae.ha@...il.com, rhee@...u.edu,
	netdev@...r.kernel.org
Subject: Re: [PATCH 3/6] tcp_cubic: fix comparison of jiffies

On 10/03/11 at 08:51 -0800, Stephen Hemminger wrote:
> --- a/net/ipv4/tcp_cubic.c	2011-03-10 08:08:32.867492953 -0800
> +++ b/net/ipv4/tcp_cubic.c	2011-03-10 08:24:39.658201745 -0800
> @@ -342,9 +342,11 @@ static void hystart_update(struct sock *
>  		u32 curr_jiffies = jiffies;
>  
>  		/* first detection parameter - ack-train detection */
> -		if (curr_jiffies - ca->last_jiffies <= msecs_to_jiffies(2)) {
> +		if ((s32)(curr_jiffies - ca->last_jiffies) <=
> +		    msecs_to_jiffies(2)) {
>  			ca->last_jiffies = curr_jiffies;
> -			if (curr_jiffies - ca->round_start >= ca->delay_min>>4)
> +			if ((s32) (curr_jiffies - ca->round_start) <=
> +			    ca->delay_min >> 4)

>=, not <=
-- 
| Lucas Nussbaum             MCF Université Nancy 2 |
| lucas.nussbaum@...ia.fr         LORIA / AlGorille |
| http://www.loria.fr/~lnussbau/  +33 3 54 95 86 19 |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html