lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Mar 2011 14:39:21 +0100 From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com> To: Jamie Iles <jamie@...ieiles.com> Cc: netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, nicolas.ferre@...el.com Subject: Re: [PATCH 2/8] macb: detect hclk presence from platform data On 13:08 Fri 11 Mar , Jamie Iles wrote: > On Fri, Mar 11, 2011 at 01:47:57PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 08:54 Fri 11 Mar , Jamie Iles wrote: > > > On Fri, Mar 11, 2011 at 02:44:00AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > On 10:10 Thu 10 Mar , Jamie Iles wrote: > > > > > +#ifdef CONFIG_ARCH_AT91 > > > > > +#define PCLK_NAME "macb_clk" > > > > > +#else /* CONFIG_ARCH_AT91 */ > > > > > +#define PCLK_NAME "pclk" > > > > > +#endif > > > > > > > > we need change the clock name and avoid the ifdef > > > > so this will be generic > > > > > > > > nb I work on the switch to clkdev currently for avr32 and at91 > > > > > > This should be gone now. Russell made the suggestion to have a fake clk > > > for hclk on AT91 so I think I've solved that now. There's an updated > > > patch in my reply to Russell's message but essentially I'm using > > > at91_clock_associate() to turn "macb_pclk" into "hclk" and "pclk". Does > > > this seem reasonable? > > please do not use at91_clock_associate as I'm going to remove it as use static > > clock as done on shmobile as example > > so if it's a fake clock please as ochi_clk on 9g45 > > Ok, that's fine. How about for the "macb_plk" though, won't that need > an at91_clock_associate() or is it OK to rename all of the macb_clk > definitions to have be called "pclk"? Personnaly I prefer macb_clk but if Nico prefer pclk it's fine Best Regards, J. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists