netdev - [PATCH 1/3] tcp_cubic: fix train length comparision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1300060992-24151-1-git-send-email-sangtae.ha@gmail.com>
Date:	Sun, 13 Mar 2011 20:03:12 -0400
From:	Sangtae Ha <sangtae.ha@...il.com>
To:	Lucas Nussbaum <lucas.nussbaum@...ia.fr>
Cc:	Stephen Hemminger <stephen.hemminger@...tta.com>,
	David Miller <davem@...emloft.net>,
	Injong Rhee <rhee@...u.edu>,
	Bill Fink <billfink@...dspring.com>, <netdev@...r.kernel.org>,
	Sangtae Ha <sangtae.ha@...il.com>
Subject: [PATCH 1/3] tcp_cubic: fix train length comparision

HyStart detects the safe exit point when the ACK train length is
larger than the one-way delay. This needs to be applied after
the patches Stephen made to fix clock dependency of HyStart.

Signed-off-by: Sangtae Ha <sangtae.ha@...il.com>
---
 net/ipv4/tcp_cubic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/tcp_cubic.c b/net/ipv4/tcp_cubic.c
index 91ef5e6..ab9f888 100644
--- a/net/ipv4/tcp_cubic.c
+++ b/net/ipv4/tcp_cubic.c
@@ -356,7 +356,7 @@ static void hystart_update(struct sock *sk, u32 delay)
 		/* first detection parameter - ack-train detection */
 		if ((s32)(now - ca->last_ack) <= hystart_ack_delta) {
 			ca->last_ack = now;
-			if ((s32)(now - ca->round_start) <= ca->delay_min >> 4)
+			if ((s32)(now - ca->round_start) > ca->delay_min >> 4)
 				ca->found |= HYSTART_ACK_TRAIN;
 		}
 
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html