netdev - Re: [PATCH] pktgen: fix transmission headers with frags=0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300112338.3423.27.camel@edumazet-laptop>
Date:	Mon, 14 Mar 2011 15:18:58 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Daniel Turull <daniel.turull@...il.com>
Cc:	netdev@...r.kernel.org, Robert Olsson <robert@...julf.net>,
	Jens Laas <jens.laas@....uu.se>,
	Voravit Tanyingyong <voravit@....se>
Subject: Re: [PATCH] pktgen: fix transmission headers with frags=0

Le lundi 14 mars 2011 à 15:13 +0100, Daniel Turull a écrit :
> On 03/14/2011 02:56 PM, Eric Dumazet wrote:

> > Good catch !
> > 
> > Hmm this patch is not correct, why memset(data + 1, ...) ?
> 
> I kept the +1 as it was in the original code, but I supposed it can be avoided.
> 

original code was assuming pgh was at right location.

pgh + 1 : really pointed to first byte after pktgen header.


data + 1 : points one byte off (so we leak one byte of kernel memory,
security guys would complain a lot...)

> I think that the second is better and more compact.
> 
> Do I resend the new patch?

Yes please ;)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html