netdev - Re: [GIT/PATCH v5] xen network backend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300131208.32696.24.camel@localhost.localdomain>
Date:	Mon, 14 Mar 2011 19:33:28 +0000
From:	Ian Campbell <Ian.Campbell@...citrix.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	xen-devel <xen-devel@...ts.xensource.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Francois Romieu <romieu@...zoreil.com>,
	Ben Hutchings <bhutchings@...arflare.com>,
	Stephen Hemminger <shemminger@...tta.com>,
	Michał Mirosław <mirqus@...il.com>
Subject: Re: [GIT/PATCH v5] xen network backend driver

On Mon, 2011-03-14 at 18:57 +0000, Eric Dumazet wrote:
> Le lundi 14 mars 2011 à 14:27 +0000, Ian Campbell a écrit :

> > +	/* Statistics */
> > +	unsigned long rx_gso_checksum_fixup;
> 
> this is an "unsigned long" field

> > +static void xenvif_get_ethtool_stats(struct net_device *dev,
> > +				     struct ethtool_stats *stats, u64 * data)
> > +{
> > +	void *vif = netdev_priv(dev);
> > +	int i;
> > +
> > +	for (i = 0; i < ARRAY_SIZE(xenvif_stats); i++)
> > +		data[i] = *(int *)(vif + xenvif_stats[i].offset);
> 
> so use : data[i] = *(unsigned long *)(vif + xenvif_stats[i].offset);

Oops, will do, thanks.

Ian.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html