netdev - Re: [PATCH] Disable rp_filter for IPsec packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D7E88C7.5080706@cbnco.com>
Date:	Mon, 14 Mar 2011 17:29:43 -0400
From:	Michael Smith <msmith@...co.com>
To:	netdev@...r.kernel.org
Subject: Re: [PATCH] Disable rp_filter for IPsec packets

David Miller wrote:
> First, I'm only willing to accept a patch like this to net-next-2.6
> for which all of the code you are changing is radically different.

OK.

> Secondly, fib_validate_source() already takes too many damn arguments.
> Find another, less costly, way to pass this information down there.

What would be a less costly way to pass it? Could I just hand it the 
whole skb?

> Frankly, I think RPF should be disabled completely by default.  When
> it doesn't do anything useful, it's making route lookups twice as
> expensive as they need to be.

Yeah, it's disabled by default. It's an easy way of preventing spoofing 
of internal source addresses from the Internet, so I like it.

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html