netdev - Re: [PATCH 1/2] NET: cdc-phonet, fix stop-queue handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110314.152334.27803075.davem@davemloft.net>
Date:	Mon, 14 Mar 2011 15:23:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	remi.denis-courmont@...ia.com
Cc:	jslaby@...e.cz, jirislaby@...il.com, netdev@...r.kernel.org,
	gregkh@...e.de, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] NET: cdc-phonet, fix stop-queue handling

From: "Rémi Denis-Courmont" <remi.denis-courmont@...ia.com>
Date: Mon, 14 Mar 2011 09:39:56 +0200

> On Sunday 13 March 2011 18:54:30 ext Jiri Slaby, you wrote:
>> Currently there is a warning emitted by the cdc-phonet driver:
>> WARNING: at include/linux/netdevice.h:1557 usbpn_probe+0x3bb/0x3f0
>> [cdc_phonet]() Modules linked in: ...
>> Pid: 5877, comm: insmod Not tainted 2.6.37.3-16-desktop #1
>> Call Trace:
>>  [<ffffffff810059b9>] dump_trace+0x79/0x340
>>  [<ffffffff81520fdc>] dump_stack+0x69/0x6f
>>  [<ffffffff810580eb>] warn_slowpath_common+0x7b/0xc0
>>  [<ffffffffa00254fb>] usbpn_probe+0x3bb/0x3f0 [cdc_phonet]
>> ...
>> ---[ end trace f5d3e02908603ab4 ]---
>> netif_stop_queue() cannot be called before register_netdev()
>> 
>> So remove netif_stop_queue from the probe funtction to avoid that.
>> 
>> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
>> Cc: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>
>> Cc: David S. Miller <davem@...emloft.net>
> 
> Acked-by: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html