netdev - Re: [PATCH NEXT 2/2] netxen: support for GbE port settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300142648.2584.76.camel@bwh-desktop>
Date:	Mon, 14 Mar 2011 22:44:08 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
Cc:	amit.salecha@...gic.com, netdev@...r.kernel.org,
	ameen.rahman@...gic.com, anirban.chakraborty@...gic.com,
	sony.chacko@...gic.com
Subject: Re: [PATCH NEXT 2/2] netxen: support for GbE port settings

On Mon, 2011-03-14 at 15:32 -0700, David Miller wrote:
> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Mon, 14 Mar 2011 22:30:22 +0000
> 
> > On Mon, 2011-03-14 at 15:15 -0700, David Miller wrote:
> >> From: Amit Kumar Salecha <amit.salecha@...gic.com>
> >> Date: Fri, 11 Mar 2011 01:50:03 -0800
> >> 
> >> > From: Sony Chacko <sony.chacko@...gic.com>
> >> > 
> >> > o Allow setting speed and auto negotiation parameters for GbE ports.
> >> > o Log an error message to indicate duplex setting is not supported in
> >> >   the hardware currently.
> >> > 
> >> > Signed-off-by: Sony Chacko <sony.chacko@...gic.com>
> >> > Signed-off-by: Amit Kumar Salecha <amit.salecha@...gic.com>
> >> 
> >> The kernel log is not the place to transmit this information.
> >> 
> >> Please work with Ben Hutchings who is working for ways to report
> >> this to the user in the proper location, via ethtool.
> > 
> > I am?  Well, patches welcome, at least.
> 
> You were discussing a scheme, I think with Intel folks, about letting
> such changes through then making ethtool re-read the settings and see
> which changes were not integrated by the driver.
> 
> Then you'd emit a diagnostic from ethtool over stderr to report any
> such discrepencies.

Only for offload settings, where the API makes it clear which flags the
user is deliberately setting and the kernel or driver can reasonably fix
up others.  For link settings, that isn't clear, and drivers should
simply reject invalid combinations.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html