netdev - Re: [PATCH net-next-2.6] ipv4: Fix PMTU update.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110313.183845.226774350.davem@davemloft.net>
Date:	Sun, 13 Mar 2011 18:38:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shimoda.hiroaki@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] ipv4: Fix PMTU update.

From: Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
Date: Thu, 10 Mar 2011 15:09:58 +0900

> On current net-next-2.6, when Linux receives ICMP Type: 3, Code: 4
> (Destination unreachable (Fragmentation needed)), 
> 
>   icmp_unreach
>     -> ip_rt_frag_needed
>          (peer->pmtu_expires is set here)
>     -> tcp_v4_err
>          -> do_pmtu_discovery
>               -> ip_rt_update_pmtu
>                    (peer->pmtu_expires is already set,
>                     so check_peer_pmtu is skipped.)
>                    -> check_peer_pmtu
> 
> check_peer_pmtu is skipped and MTU is not updated.
> 
> To fix this, let check_peer_pmtu execute unconditionally.
> And some minor fixes
> 1) Avoid potential peer->pmtu_expires set to be zero.
> 2) In check_peer_pmtu, argument of time_before is reversed.
> 3) check_peer_pmtu expects peer->pmtu_orig is initialized as zero,
>    but not initialized.
> 
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@...il.com>

This looks great, thanks for fixing this bug.

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html