netdev - Re: [PATCH net-next-2.6] ftmac100: use GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=grwkfYpBFJEyQHXbFaTov5Tc+tAR2ebzw0Bht@mail.gmail.com>
Date:	Mon, 14 Mar 2011 16:16:06 +0800
From:	Po-Yu Chuang <ratbert.chuang@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Po-Yu Chuang <ratbert@...aday-tech.com>
Subject: Re: [PATCH net-next-2.6] ftmac100: use GFP_ATOMIC allocations where needed

Hi Eric,

On Mon, Mar 14, 2011 at 4:29 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> Le dimanche 13 mars 2011 à 21:26 +0100, Eric Dumazet a écrit :
>> Le dimanche 13 mars 2011 à 21:16 +0100, Eric Dumazet a écrit :
>>
>> > BTW, it seems I missed the fact that ftmac100_alloc_rx_page() used a
>> > GFP_KERNEL allocation, while its called from softirq context (from
>> > ftmac100_rx_packet())
>>
>> Here is a patch against ftmac100
>>
>
> Oops, one typo in it sorry
>
>> -static int ftmac100_alloc_rx_page(struct ftmac100 *priv, struct ftmac100_rxdes *rxdes)
>> +static int ftmac100_alloc_rx_page(struct ftmac100 *priv,
>> +                               struct ftmac100_rxdes *rxdes, gtp_t gfp)
>
> Should be :   gfp_t gfp
>
> Please build and test the patch, I dont have an ARM testbed anyway.

Tested-by: Po-Yu Chuang <ratbert@...aday-tech.com>

Thank you,
Po-Yu Chuang
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html