netdev - Re: [PATCH 02/20] ipvs: reorganize tot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1103141104070.1736@ja.ssi.bg>
Date:	Mon, 14 Mar 2011 11:21:21 +0200 (EET)
From:	Julian Anastasov <ja@....bg>
To:	Eric Dumazet <eric.dumazet@...il.com>
cc:	Simon Horman <horms@...ge.net.au>, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org,
	lvs-devel@...r.kernel.org, Hans Schillstrom <hans@...illstrom.com>
Subject: Re: [PATCH 02/20] ipvs: reorganize tot_stats

 	Hello,

On Mon, 14 Mar 2011, Eric Dumazet wrote:

>>  	Also, make sure ip_vs_stats_percpu_show reads properly
>> the u64 stats from user context.
>>
>> Signed-off-by: Julian Anastasov <ja@....bg>
>> Signed-off-by: Simon Horman <horms@...ge.net.au>
>
> Reviewed-by: Eric Dumazet <eric.dumazet@...il.com>
>
> One comment : per cpu stats are really good to avoid cache misses, but I
> see tot_stats is included in struct netns_ipvs right after "conn_count",
> possibly sharing a hot cache line ?

 	conn_count and tcp_app_lock, udp_app_lock, sctp_app_lock
are used when packet creates new connection, probably on the
same time depending on the protocol in packet. May be conn_count
better to be before tcp_apps, far away from some sysctl vars
that are mostly read?

 	For tot_stats: cpustats ptr is always read,
other fields in tot_stats are updated from the 2-second
timer. May be it is better just to move tot_stats before
est_list, it is written at the same time?

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html