netdev - Re: Stale entries in RT_TABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1103151033260.1729@ja.ssi.bg>
Date:	Tue, 15 Mar 2011 10:47:20 +0200 (EET)
From:	Julian Anastasov <ja@....bg>
To:	Alex Sidorenko <alexandre.sidorenko@...com>
cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: Stale entries in RT_TABLE_LOCAL


 	Hello,

On Thu, 10 Mar 2011, Alex Sidorenko wrote:

>> IP1: 192.168.140.31/22, primary
>> IP2: 192.168.142.109/23, primary
>> IP3: 192.168.142.109/22, secondary for primary IP1
>>
>>         It is the route for IP3 that is leaked, with prefsrc=IP1.
>> We create local route for secondary IPs with prefsrc=ItsPrimaryIP.
>> Both local routes for 109 differ in prefsrc (fa_info). But on
>> deletion only one route is deleted due to last_ip check - the first
>> because on deletion prefsrc is not matched, fib_table_delete
>> does not work in symmetric way. So, the local route created
>> for IP3 remains no matter the deletion order.
>> If we decide to create one unique local route for this case,
>> there is a risk device unregistration to remove
>> it (fib_sync_down_dev with force > 0).
>
> Yes, but do we _really_ need to be able to add the same IP multiple times
> (with different masks)? If not, we can just return an error when someine tries
> to add the same IP again with different mask.

 	Yes, it seems one IP can be part of different subnets,
even with different scope. We can create compatibility
problems for users that use it in this way. I found more
issues with the secondary address promotion and broadcast
address deletion, it will take 2-3 days to prepare some
patches and test script for all these problems.

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html