netdev - Re: [RFC v3 0/6] CAN: add SAE J1939 protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110315092341.GA332@e-circ.dyndns.org>
Date:	Tue, 15 Mar 2011 10:23:41 +0100
From:	Kurt Van Dijck <kurt.van.dijck@....be>
To:	socketcan-core@...ts.berlios.de, netdev@...r.kernel.org
Subject: Re: [RFC v3 0/6] CAN: add SAE J1939 protocol

On Mon, Mar 14, 2011 at 02:20:04PM +0100, Kurt Van Dijck wrote:
> 
> This series adds SAE J1939 support to the current net-next-2.6.
> For the rtnetlink operations to work, a 2.6.38-rc1 is required.
> 
> 1/6: can: extend sockaddr_can to include j1939 members
> 2/6: can: add rtnetlink support
> 3/6: can: make struct proto const
> 4/6: j1939: initial import of SAE J1939
> 5/6: j1939: add documentation & MAINTAINERS
> 6/6: iproute2: use CAN & J1939
> 
> Still a lot of things probably need explanation...

I had not mentioned the major differences with v2
(which went to berlios SocketCAN mailing list only).

* replace magic constants with macro's
* use a static protocol stack, not a dynamic one.
* remove feature that have limited use and are
  difficult to explain.
* renamed some structure types to increase code readability. 
* block on transport sessions until CAN frame is queued.

* fix bugs.

Kurt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html