[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20110315.185424.193707215.davem@davemloft.net>
Date: Tue, 15 Mar 2011 18:54:24 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: eric.dumazet@...il.com
Cc: chromatix99@...il.com, d@...t.net, netdev@...r.kernel.org,
dan@...erfire.com
Subject: Re: [PATCH] net_sched: fix ip_tos2prio
From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 16 Mar 2011 00:56:07 +0100
> From: Dan Siemon <dan@...erfire.com>
>
> ECN support incorrectly maps ECN BESTEFFORT packets to TC_PRIO_FILLER
> (1) instead of TC_PRIO_BESTEFFORT (0)
>
> This means ECN enabled flows are placed in pfifo_fast/prio low priority
> band, giving ECN enabled flows [ECT(0) and CE codepoints] higher drop
> probabilities.
>
> This is rather unfortunate, given we would like ECN being more widely
> used.
>
> Ref : http://www.coverfire.com/archives/2011/03/13/pfifo_fast-and-ecn/
>
> Signed-off-by: Dan Siemon <dan@...erfire.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Dave Täht <d@...t.net>
> Cc: Jonathan Morton <chromatix99@...il.com>
Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists