| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1300383174.25808.21.camel@HP1> Date: Thu, 17 Mar 2011 10:32:54 -0700 From: "Michael Chan" <mchan@...adcom.com> To: "David Miller" <davem@...emloft.net> cc: "Eilon Greenstein" <eilong@...adcom.com>, "Ariel Elior" <ariele@...adcom.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH net-dev2.6] bxn2x: Fix location of PCI-ids defines On Thu, 2011-03-17 at 08:10 -0700, David Miller wrote: > From: "Eilon Greenstein" <eilong@...adcom.com> > Date: Thu, 17 Mar 2011 15:13:33 +0200 > > > On Thu, 2011-03-17 at 06:06 -0700, David Miller wrote: > >> From: "Ariel Elior" <ariele@...adcom.com> > >> Date: Thu, 17 Mar 2011 14:27:04 +0200 > >> > >> > Signed-off-by: Ariel Elior <ariele@...adcom.com> > >> > Signed-off-by: Eilon Greenstein <eilong@...adcom.com> > >> > >> Unless you intend to reference these symbols elsewhere in the > >> kernel, they should stay private in your driver. > >> > > > > The bnx2i will need it as well. Isn't it better to keep all the PCI IDs > > in the same global location? > > If they are used in more than one driver, yes. We already sent a similar patch through the scsi tree. It is now in the linux-next tree: http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=8a4a0f3ad071e258a9637c5491c34005a9a97903 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists