netdev - Re: patch for format issues and header bug in net/ipv4/icmp.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300477261.2589.28.camel@bwh-desktop>
Date:	Fri, 18 Mar 2011 19:41:01 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jeffrin Jose <ahiliation@...oo.co.in>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: patch for format issues and header bug in net/ipv4/icmp.c

On Sat, 2011-03-19 at 00:05 +0530, Jeffrin Jose wrote:
> hello ,
> 
> I have created a patch for net/ipv4/icmp.c
> using checkpatch.pl script to fix several warnings
> and an error.

You need to learn C programming before trying to correct C programs.
You should not just do what it takes to make checkpatch.pl happy.

Ben.

> I have attached the patch along with this mail.
> 
> /Thanks
> 

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html