netdev - Re: [PATCH] ethtool: __ethtool_set_sg: check for function pointer before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110318.151559.13735292.davem@davemloft.net>
Date:	Fri, 18 Mar 2011 15:15:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	rl@...lgate.ch, mirq-linux@...e.qmqm.pl, netdev@...r.kernel.org
Subject: Re: [PATCH] ethtool: __ethtool_set_sg: check for function pointer
 before using it

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 17 Mar 2011 16:52:13 +0000

> On Thu, 2011-03-17 at 17:37 +0100, Roger Luethi wrote:
>> __ethtool_set_sg does not check if dev->ethtool_ops->set_sg is defined
>> which can result in a NULL pointer dereference when ethtool is used to
>> change SG settings for drivers without SG support.
>> 
>> Signed-off-by: Roger Luethi <rl@...lgate.ch>
> Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html