netdev - Re: [PATCH] headers: use __aligned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110318162826.5295f130.akpm@linux-foundation.org>
Date:	Fri, 18 Mar 2011 16:28:26 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] headers: use __aligned_xx types for userspace

On Fri, 18 Mar 2011 14:50:37 -0400
Mike Frysinger <vapier@...too.org> wrote:

> Now that we finally have __aligned_xx exported to userspace, convert
> the headers that get exported over to the proper type.
> 

Sob.  Please don't assume that because you're on top of an issue, all
the rest of us are.

A bit of git-log grovelling turns up

: commit 79b5dc0c64d88cda3da23b2e22a5cec0964372ac
: Author: Eric Paris <eparis@...hat.com>
: Date:   Fri Oct 15 14:34:14 2010 -0700                                          
:     types.h: define __aligned_u64 and expose to userspace
:     
:     We currently have a kernel internal type called aligned_u64 which aligns
:     __u64's on 8 bytes boundaries even on systems which would normally align
:     them on 4 byte boundaries.  This patch creates a new type __aligned_u64
:     which does the same thing but which is exposed to userspace rather than
:     being kernel internal.                                                    

but that really doesn't tell us why it was merged either.  Perhaps that
came out in the followup discussion and I failed to fix the changelog.

Still, it doesn't hurt to educate people.  Please explain why we are
making this change?

>  include/linux/if_ppp.h                    |   16 ++++++++--------
>  include/linux/netfilter/nfnetlink_log.h   |    4 ++--
>  include/linux/netfilter/nfnetlink_queue.h |    4 ++--
>  include/linux/netfilter/xt_connbytes.h    |    4 ++--
>  include/linux/netfilter/xt_quota.h        |    2 +-
>  5 files changed, 15 insertions(+), 15 deletions(-)

davem stuff :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html