netdev - Re: [PATCH] netfilter: xtables: fix reentrancy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1300445427.2888.23.camel@edumazet-laptop>
Date:	Fri, 18 Mar 2011 11:50:27 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jesper Dangaard Brouer <hawk@...u.dk>
Cc:	David Miller <davem@...emloft.net>,
	Patrick McHardy <kaber@...sh.net>,
	Netfilter Developers <netfilter-devel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] netfilter: xtables: fix reentrancy

Le vendredi 18 mars 2011 à 11:27 +0100, Jesper Dangaard Brouer a écrit :

> I have actually enabled PREEMPTion, am I in trouble then?
> 

Well, to get problem on localy generated trafic (as all forwarding is
done from softirq handler), you'll need a malicious -j RETURN in OUTPUT
hook (in the OUTPUT chain, not a called one)

Also, even for localy generated trafic, I guess most callers block BH
before calling ipt_do_table() anyway...

> I have modified the .config I got from you, quite a lot, during my 
> attempts to find the CCISS/HPSA problem.
> 
> Which reminds me that I needed to enable, the follwing config options, 
> (which your config didn't have):
>   CONFIG_PCIEASPM=y
>   CONFIG_X86_X2APIC=y
> 
> In order to get rid of a PCI warning:
>   NMI: PCI system error (SERR) for reason b1 on CPU 0.
>   Dazed and confused, but trying to continue
> 
> The system worked fine, and you might not see this issue on your G6 
> servers, as its most likely BIOS related (my server is a HP DL370 G6).
> 

Mine is ProLiant BL460c G6

> FYI: Operations have deployed the kernel on prod server this morning.

Okay, lets pray ;)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html