netdev - Re: LRO disable warnings on kernel 2.6.38

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110318081524.42d18bd2@nehalam>
Date:	Fri, 18 Mar 2011 08:15:24 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>,
	Jesper Dangaard Brouer <jdb@...x.dk>,
	netdev <netdev@...r.kernel.org>,
	Neil Horman <nhorman@...driver.com>,
	Alexander Duyck <alexander.h.duyck@...el.com>
Subject: Re: LRO disable warnings on kernel 2.6.38

On Fri, 18 Mar 2011 15:33:04 +0100
Eric Dumazet <eric.dumazet@...il.com> wrote:

> Le vendredi 18 mars 2011 à 14:17 +0000, Ben Hutchings a écrit :
> 
> > WARN is correct as this is a driver bug.  But I agree that the
> > device/driver ID should be included.
> 
> stack trace gives absolutely no useful indication here.
> 
> Bug is in driver, yet we dump information on core network stack ?
> 
> pr_err() is an error indication, not a warning by the way ;)

The advantage of WARN is that it doesn't get ignored and shows
up in kernel oops. But agreed it should print out as much device
info as possible to finger the broken device driver.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html