netdev - Re: [PATCH] r8169: fix a bug in rtl8169_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201103191641.41718.oliver@neukum.org>
Date:	Sat, 19 Mar 2011 16:41:41 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Anca Emanuel <anca.emanuel@...il.com>, piotr@...owicz.com,
	LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org,
	Francois Romieu <romieu@...zoreil.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] r8169: fix a bug in rtl8169_init_phy()

Am Samstag, 19. März 2011, 16:39:11 schrieben Sie:
> Le samedi 19 mars 2011 à 16:33 +0100, Eric Dumazet a écrit :
> > Le samedi 19 mars 2011 à 16:31 +0100, Oliver Neukum a écrit :
> > > Am Samstag, 19. März 2011, 16:18:50 schrieb Eric Dumazet:
> > > 
> > > > Problem comes from commit 54405cde762408b00a445466a40da4f7f33a8479
> > > > (r8169: support control of advertising.)
> > > > 
> > > > Reverting it brings back NIC for me
> > > 
> > > Odd. It worked for me. Are you testing on a gigabit switch? Could you send
> > > me dmesg? Does it work if you use ethtool to advertise a lower speed?
> > > 
> > > 	Regards
> > > 		Oliver
> > 
> > I found the bug, I am sending a patch in two minutes.
> > 
> 
> Here it is
> 
> [PATCH] r8169: fix a bug in rtl8169_init_phy()
> 
> commit 54405cde7624 (r8169: support control of advertising.)
> introduced a bug in rtl8169_init_phy()

Thank you. I feel like banging my head against something.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html