[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20110319.133838.71107089.davem@davemloft.net>
Date: Sat, 19 Mar 2011 13:38:38 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: eric.dumazet@...il.com
Cc: oliver@...kum.org, anca.emanuel@...il.com, piotr@...owicz.com,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
romieu@...zoreil.com, torvalds@...ux-foundation.org
Subject: Re: [PATCH] r8169: fix a bug in rtl8169_init_phy()
From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 19 Mar 2011 16:39:11 +0100
> [PATCH] r8169: fix a bug in rtl8169_init_phy()
>
> commit 54405cde7624 (r8169: support control of advertising.)
> introduced a bug in rtl8169_init_phy()
>
> Reported-by: Piotr Hosowicz <piotr@...owicz.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
Applied to net-2.6, thanks Eric.
Linus, this is definitely the bug you were seeing too.
> Cc: Oliver Neukum <oliver@...kum.org>
> Cc: Francois Romieu <romieu@...zoreil.com>
> ---
> drivers/net/r8169.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index 5e40351..493b0de 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -2685,9 +2685,9 @@ static void rtl8169_init_phy(struct net_device *dev, struct rtl8169_private *tp)
> rtl8169_set_speed(dev, AUTONEG_ENABLE, SPEED_1000, DUPLEX_FULL,
> ADVERTISED_10baseT_Half | ADVERTISED_10baseT_Full |
> ADVERTISED_100baseT_Half | ADVERTISED_100baseT_Full |
> - tp->mii.supports_gmii ?
> + (tp->mii.supports_gmii ?
> ADVERTISED_1000baseT_Half |
> - ADVERTISED_1000baseT_Full : 0);
> + ADVERTISED_1000baseT_Full : 0));
>
> if (RTL_R8(PHYstatus) & TBI_Enable)
> netif_info(tp, link, dev, "TBI auto-negotiating\n");
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists