netdev - [PATCH 1/1] solos-pci: Fix debugging to include size, vpi/vci, but omit preamble

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4D85B12E.5040005@redfish-solutions.com>
Date:	Sun, 20 Mar 2011 00:47:58 -0700
From:	Philip Prindeville <philipp_subx@...fish-solutions.com>
To:	Netdev <netdev@...r.kernel.org>
CC:	"linux-atm-general@...ts.sourceforge.net" 
	<linux-atm-general@...ts.sourceforge.net>
Subject: [PATCH 1/1] solos-pci: Fix debugging to include size, vpi/vci, but
 omit preamble

Show the buffer length, vpi, and vci as we do on receive.  Use the word "port" instead of "device" consistently.

Don't display the "struct pkt_hdr" preamble on the sk_buff when doing hexdump of frame data.

Signed-off-by: Philip Prindeville <philipp@...fish-solutions.com>
---

--- a/drivers/atm/solos-pci.c.orig	2011-03-19 12:19:06.000000000 -0600
+++ b/drivers/atm/solos-pci.c	2011-03-19 12:45:18.000000000 -0600
@@ -697,7 +697,7 @@ void solos_bh(unsigned long card_arg)
  					      size);
  			}
  			if (atmdebug) {
-				dev_info(&card->dev->dev, "Received: device %d\n", port);
+				dev_info(&card->dev->dev, "Received: port %d\n", port);
  				dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",
  					 size, le16_to_cpu(header->vpi),
  					 le16_to_cpu(header->vci));
@@ -1025,8 +1025,15 @@ static uint32_t fpga_tx(struct solos_car

  			/* Clean up and free oldskb now it's gone */
  			if (atmdebug) {
+				struct pkt_hdr *header = (void *)oldskb->data;
+				int size = le16_to_cpu(header->size);
+
+				skb_pull(oldskb, sizeof(*header));
  				dev_info(&card->dev->dev, "Transmitted: port %d\n",
  					 port);
+				dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",
+					 size, le16_to_cpu(header->vpi),
+					 le16_to_cpu(header->vci));
  				print_buffer(oldskb);
  			}



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html